Remove TwinPhasedX and replace with individual PhasedX in rebases#1485
Remove TwinPhasedX and replace with individual PhasedX in rebases#1485jake-arkinstall merged 3 commits intofeat/sol-gatesetfrom
TwinPhasedX and replace with individual PhasedX in rebases#1485Conversation
cqc-alec
requested review from
aborgna-q
and removed request for
a team and
aborgna-q
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/sol-gateset #1485 +/- ##
====================================================
+ Coverage 83.26% 83.29% +0.02%
====================================================
Files 188 188
Lines 29370 29347 -23
Branches 28259 28239 -20
====================================================
- Hits 24456 24445 -11
+ Misses 3760 3747 -13
- Partials 1154 1155 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| let [a, c] = self.add_phased_xx(platform, a, c, pi_2, zero)?; | ||
| let [a, c] = self.add_twin_phased_x(platform, a, c, pi_2, pi_minus_2)?; | ||
| let a = self.add_phased_x(platform, a, pi_2, pi_minus_2)?; |
There was a problem hiding this comment.
I'll leave approval to Jake so he can review the other components, but I'll at least confirm that the replacement of add_twin_phased_x with add_phased_x looks right to me
cqc-alec
force-pushed
the
ae/notwinphasedx
branch
from
59a5c69 to
6257742
Compare
|
I think the snapshot test failures are independent of the main change here. (They were already failing.) |
|
tket2 has moved on somewhat since my original sol rebase PR. I'll rebase that first, then I'll rebase this PR on the result. |
jake-arkinstall
force-pushed
the
feat/sol-gateset
branch
from
873c817 to
b8fc25e
Compare
jake-arkinstall
force-pushed
the
ae/notwinphasedx
branch
from
6257742 to
6705fc4
Compare
jake-arkinstall
left a comment
jake-arkinstall
left a comment
There was a problem hiding this comment.
LGTM after rebasing
3 participants
No description provided.