feat(const-fold): write prepopulated inputs, place fewer Consts + next to source not targets#1489
Open
feat(const-fold): write prepopulated inputs, place fewer Consts + next to source not targets#1489
Conversation
7fe677f to
88d3803
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 83.81% 83.82% +0.01%
==========================================
Files 187 187
Lines 28943 28956 +13
Branches 27880 27877 -3
==========================================
+ Hits 24258 24273 +15
+ Misses 3523 3522 -1
+ Partials 1162 1161 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
88d3803 to
8feb879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
mb_root_inpwas used to prevent values passed toprepopulate_wire/prepopulate_inputsbeing written into the graph - I think at the time I did this because writing them in seemed a bit superfluous, but really it's consistent with what we do to other ops. Hence, drop themb_root_inp.Prior to #1474 (now merged) this broke lots of things because
mb_root_inpwas covering that bug. Post #1474 this breaks only a few cases inconst_fold::test::test_cfgwhich were callingassert_fully_foldedInputnodes for which values were being provided byprepopulate_inputs. Themb_root_inpwas preventing these from being written into the graph, but without that, they are written into the graph which wre are checking is fully folded and so it doesn't match the expected form. (Specifically,assert_fully_foldedlooks for the nodes you'd expect in a DFG; we are running it on a BasicBlock in a CFG, and the fed-in constant values are the successor-predicate)