Add support for higher-order derivatives #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessary `return` in rrule
yitan1
changed the title
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
requested changes
Dec 11, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I have only one minor comment, otherwise happy to merge this.
| @non_differentiable TensorOperations.tensorcontract_structure(args...) | ||
| @non_differentiable TensorOperations.tensorcontract_type(args...) | ||
| @non_differentiable TensorOperations.tensoralloc_contract(args...) | ||
| @non_differentiable Base.promote_op(args...) |
Member
There was a problem hiding this comment.
Do you know if your example also works if this isn't included? We can't really do this here since that is type piracy, so we would have to find an alternative way around this...
Suggested change
| @non_differentiable Base.promote_op(args...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #227 by following changes
@non_differentiableforBase.promote_optensorscalarto avoid inplace functionreturnfromrrule