-
-
Notifications
You must be signed in to change notification settings - Fork 56
Add flatpak update plugin for system-wide flatpaks #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alimirjamali
wants to merge
1
commit into
QubesOS:main
Choose a base branch
from
alimirjamali:flatpak-update-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # coding=utf-8 | ||
| # | ||
| # The Qubes OS Project, http://www.qubes-os.org | ||
| # | ||
| # Copyright (C) 2025 Ali Mirjamali <[email protected]> | ||
| # | ||
| # This program is free software; you can redistribute it and/or | ||
| # modify it under the terms of the GNU General Public License | ||
| # as published by the Free Software Foundation; either version 2 | ||
| # of the License, or (at your option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program; if not, write to the Free Software | ||
| # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, | ||
| # USA. | ||
|
|
||
| import subprocess | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| def flatpak_updater(os_data, log, **kwargs): | ||
| """ | ||
| Distro agnostic plugin to update system-wide flatpaks | ||
| """ | ||
|
|
||
| if not Path("/usr/bin/flatpak"): | ||
| return | ||
| log.info("Flatpak is installed. Checking for flatpak updates.") | ||
| if not subprocess.Popen( | ||
| ["flatpak", "remote-ls", "--system", "--updates"], | ||
| stdout=subprocess.PIPE | ||
| ).stdout.read().decode().strip(): | ||
|
Comment on lines
+34
to
+37
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should consider exit code (and report as update failure, not "no updates". |
||
| log.info("No flatpak updates found.") | ||
| return | ||
| log.info("Flatpak updates found. Updating flatpaks...") | ||
| subprocess.run( | ||
| ["flatpak", "update", "--system", "--noninteractive", "-y"] | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean
.exists()? but then, I don't think you can assume it's always/usr/bin, especially with NixOS existing out there...We use
distutils.spawn.find_executable()in various placesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where?
distutilsis deprecated since version 3.10, removed in version 3.12.Anyways, I will replace it with appropriate supported lib (i.e.
shutil.which).