Skip to content

ext/block: do not suppress device-removed event on VM shutdown #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025
Merged

ext/block: do not suppress device-removed event on VM shutdown #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qubes/ext/block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,10 +646,10 @@ async def on_domain_shutdown(self, vm, event, **_kwargs):
new_cache[domain.name] = {}
if domain == vm:
for dev_id, front_vm in self.devices_cache[domain.name].items():
if front_vm is None:
continue
dev = BlockDevice(Port(vm, dev_id, "block"))
vm.fire_event("device-removed:block", port=dev.port)
if front_vm is None:
continue
await self.detach_and_notify(front_vm, dev.port)
continue
for dev_id, front_vm in self.devices_cache[domain.name].items():
Expand Down