Inform how to debug failed preload startup #729
Conversation
|
The message is quite long:
But if I used only the service name |
|
PipelineRetryFailed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 70.55% 70.39% -0.16%
==========================================
Files 61 61
Lines 13642 13673 +31
==========================================
Hits 9625 9625
- Misses 4017 4048 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I would say it's still okay to use shorter name, it's an implementation detail how it's called. |
| # let anyone receiving domain-pre-start know that startup failed | ||
| await self.fire_event_async( | ||
| "domain-start-failed", reason=str(exc) | ||
| ) |
There was a problem hiding this comment.
Does moving it actually helps anything? This code (intentionally) does not wait until all clients process an event, so there is no guarantee that qui-domains will still see the VM. Or is it about order of events if kill triggers domain-delete event?
There was a problem hiding this comment.
It helps as without that, the event will never reach the clients as domain-shutdown and domain-delete from the self.kill() will reach first, thus it will stop tracking the qube. Now that the event is fired before the kill(), it can reach the qui-domains to emit the domain-start-failed notification.
The "domain-start-failed" has to be fired before the domain is killed, as the qube is unregistered from clients when it is removed/powered off. Fixes: QubesOS/qubes-issues#10200 For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-err-msg
branch
from
7f335d9 to
c763da4
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025091910-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests30 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 80 fixed
Unstable testsPerformance TestsPerformance degradation:16 performance degradations
Remaining performance tests:156 tests
|
3 participants
The "domain-start-failed" has to be fired before the domain is killed, as the qube is unregistered from clients when it is removed/powered off.
Fixes: QubesOS/qubes-issues#10200
For: QubesOS/qubes-issues#1512