-
-
Notifications
You must be signed in to change notification settings - Fork 115
Wait for memory by transfer speed #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1d9400d to
c13626c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 70.55% 70.39% -0.17%
==========================================
Files 61 61
Lines 13616 13673 +57
==========================================
+ Hits 9607 9625 +18
- Misses 4009 4048 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025091715-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests17 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 84 fixed
Unstable testsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:160 tests
|
qubes/qmemman/systemstate.py
Outdated
| diff = round(dom.mem_actual / memset_reqs[domid], 2) | ||
| if domid not in succeeded and diff <= mem_set_threshold: | ||
| succeeded.append(domid) | ||
| self.log.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will print on every iteration, IMO should be debug level, not info.
c13626c to
b52eccd
Compare
|
I don't see any qmeman logs on https://openqa.qubes-os.org/tests/153240#downloads, I presume it is fine. |
|
Logs are not collected on successful runs... |
Fixes: QubesOS/qubes-issues#10143
For: QubesOS/qubes-issues#1512
More testing to be done.