-
Notifications
You must be signed in to change notification settings - Fork 32
Fix TestClient::test_run_dom0_service_socket_no_read #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't close server before source. Otherwise the read to source can fail with "Broken pipe".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 78.74% 78.71% -0.03%
==========================================
Files 55 55
Lines 10382 10382
==========================================
- Hits 8175 8172 -3
- Misses 2207 2210 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Based on local testing the change of coverage in qrexec/tests/socket/qrexec.py is unrelated to this change (even with this change I sometimes get coverage of that branch and sometimes not). |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025050820-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests29 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 13 fixed
Unstable testsPerformance TestsPerformance degradation:20 performance degradations
Remaining performance tests:52 tests
|
Don't close server before source. Otherwise the read to source can fail with "Broken pipe".
That is unless I misunderstood the intended behavior in this test case. In that case the implementation needs to be fixed.