anon gateway warning box on main qubesmanager page #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guiiix
force-pushed
the
anon_warning_main
branch
2 times, most recently
from
695371e to
e4cc597
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 68.89% 68.92% +0.03%
==========================================
Files 17 17
Lines 3838 3846 +8
==========================================
+ Hits 2644 2651 +7
- Misses 1194 1195 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marmarek
requested changes
Apr 27, 2025
qubesmanager/qube_manager.py
Outdated
| QMessageBox.StandardButton.Yes | | ||
| QMessageBox.StandardButton.Cancel) | ||
| # pylint: disable=possibly-used-before-assignment | ||
| if netvm_name and check_power and netvm and not netvm.is_running(): |
Member
There was a problem hiding this comment.
This can be simplified to avoid checking both netvm_name and netvm, you just need to initialize netvm = None at the start of the function. This will also avoid the pylint complain (you may also need to initialize check_power too).
Guiiix
force-pushed
the
anon_warning_main
branch
from
e4cc597 to
b682d54
Compare
This was referenced Apr 28, 2025
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025042723-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable testsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:55 tests
|
This was referenced Apr 28, 2025
marmarek
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
Originally posted by @adrelanos in #8551