Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake package #22

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Cmake package #22

wants to merge 1 commit into from

Conversation

Murmele
Copy link

@Murmele Murmele commented Dec 28, 2020

CMake support for qucsator. Needed by qucs cmake

@felix-salfelder
Copy link
Member

please squash into one commit and remove all whitespace changes. I think this should be rebased to the qucsator:develop branch (updated).

Then, maybe ask Guilherme to have a look. Iirc, he has implemented this.

@Murmele
Copy link
Author

Murmele commented Dec 28, 2020

I think it is not good to squash the history, because then it is gone. And in the FAQ.md I sumarized the problems I had and there solutions where I referenced by commit id.

@felix-salfelder
Copy link
Member

felix-salfelder commented Dec 28, 2020 via email

- Add cmake support
@felix-salfelder
Copy link
Member

Breaks make check. I suspect the changes to include statements. Please debug (revert?). Some of the changes look useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants