Improve keybinds #303
Open
Improve keybinds #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trl + c is copy on windows use InputMap instead of KeyListener in EditorPanel and eliminate EditorPopupMenu::handleKeyEvent simplify EditorPanel ctrl + click to navigate logic
fix inverted EditKeyBindDialog::isNewCombination
use InputMap instead of key listener in JavadocDialog
ix0rai
added
bug
Draft
ix0rai
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
looks great! this is giving me a few ideas for other improvements to keybinds:
- improve the logic of the keybinding menus
- when editing an individual keybind, "save" does not save to config. the keybinding will only be saved when the other save button (same text!) is pressed in the top-level menu. very unintuitive
- "save" is on the left, with no visual differentiation. it's common in UI to put the continue button on the left, but usually with accent colour in order to show which to press. we should look at adding colour like what is seen on the "save as" dialog:
- minor bug: you can create multiple of the exact same keybind (if the keybind is ctrl+shift+f, i can just add a second ctrl+shift+f without issue)
- the config file is unreadable:
[key_codes]
search = ["70;c0", "70;c0"]
search_field = ["76;c0"]we should look at either adding comments to describe what the bindings actually are or changing the encoding to something human-readable.
ANYWAY. i'm just yapping i'll break all that out into separate issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
InputMaps+ActionMaps instead ofKeyListeners forKeyBinds.Also:
isNewCombinationwas inverted)EditorPanelctrl+click to navigate logicEDITOR_SHOW_CALLSbinding toctrl + alt + cbecausectrl + cis copy on windows (before it was both copying and showing calls)