Fix 91 #306
Merged
Fix 91 #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add JavaClassProvider which provied java.* classes add CombinedJarIndex which indexes main jar and libraries added missing translation for "progress.jar.indexing.libraries"
keep lib classes whose fields or methods are referenced in the main jar
check if method is indexed in EnigmaProject::isLibraryMethodOverride
…yzerExceptions; BREAK QuiltMC#274
supersaiyansubtlety
added
bug
ix0rai
approved these changes
Nov 9, 2025
enigma/src/main/java/org/quiltmc/enigma/api/analysis/index/jar/CombinedJarIndex.java
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/api/analysis/index/jar/InheritanceIndex.java
Show resolved
Hide resolved
enigma/src/main/java/org/quiltmc/enigma/api/class_provider/JavaClassProvider.java
Show resolved
Hide resolved
Co-authored-by: ix0rai <[email protected]>
ix0rai
added a commit
that referenced
this pull request
Nov 16, 2025
* OUT OF MEMORY when trying to run all tests add JavaClassProvider which provied java.* classes add CombinedJarIndex which indexes main jar and libraries added missing translation for "progress.jar.indexing.libraries" * make methods that trace back to non-jar methods non-renamable * checkstyle * filter out unreferenced classNames for LibrariesJarIndex and CombinedJarIndex * add ReferenceIndex::getFieldsReferencedBy keep lib classes whose fields or methods are referenced in the main jar * exclude java/io/PrintStream from JavaClassProvider check if method is indexed in EnigmaProject::isLibraryMethodOverride * update asm (AnalyzerExceptions persist) * use ClasspathClassProvider instead of JavaClassProvider to avoid AnalyzerExceptions; BREAK #274 * stop excluding Object from InheritanceIndex and update tests; fix #91 * update TODO * try finding child node instead of assuming it's first * add clarifying comment to UN_ANALYZABLE_CLASS_NAMES Co-authored-by: ix0rai <[email protected]> * add jar index javadocs --------- Co-authored-by: ix0rai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91
repurposed from my fix for #274 that was plagued by
AnalyzerExceptions when used by QMapthis:
Enigma's lib indexEnigmaEntryRemapperinstead of the main jar indexjava/lang/Object's explicit exclusion fromInheritanceIndex(added in this commit)Also adds but does not use
JavaClassProviderwhich can be swapped forClasspathClassProviderto fix more of #274 onceAnalyzerExceptions are sorted.When squash-merging, be sure to change the commit message about fixing #274 so it doesn't get prematurely closed.