Skip to content

feat: scheduler rewrite #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 38 commits into
base: build/v2
Choose a base branch
from
Draft

feat: scheduler rewrite #7816

wants to merge 38 commits into from

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Aug 13, 2025 •
edited
Loading

Scheduler rewrite to support processing multiple async chores at once.

Fixes: #7296 #7416 #7795

@Varixo Varixo self-assigned this Aug 13, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e832504

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo force-pushed the v2-scheduler-rewrite branch from 1f0ec3c to b86f8a3 Compare August 13, 2025 15:09
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 13, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7816

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7816

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7816

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7816

commit: e832504

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview e832504

@Varixo Varixo moved this from Backlog to In progress in Qwik Development Aug 13, 2025
Varixo added 21 commits August 16, 2025 15:33
@Varixo
WIP: scheduler rewrite
5a13225 
Co-Authored-By: [email protected]
@Varixo
fix: schedule store effects
6d9f3cf
@Varixo
fix test to be correct
46808d1
@Varixo
fix: ref test
e611c0d
@Varixo
WIP: render done promise
90a8083 
# Conflicts:
#	packages/qwik-router/src/runtime/src/qwik-router-component.tsx
@Varixo
fix: use correct qinit event name
699fdf1
@Varixo
feat: implement blocking rules logic
d6c3ef8
@Varixo
feat: block already scheduled chores if needed before execution
ca66382
@Varixo
fix: don't schedule effect for array store targets for removing
52272c2
@Varixo
fix: inserting errored-host
ee55d2b
@Varixo
fix: immediately run RUN_QRL chores
3645f09
@Varixo
fix: prevent running journal flush multiple times at the same time
ba362a5
@Varixo
fix: don't schedule chore if it is already running
489780f
@Varixo
fix: unit tests await for queue
5e49e7a
@Varixo
fix: processing deleted vnode
13bc691
@Varixo
feat: use setImmediate or MessageChannel as next tick
b02fa6f
@Varixo
fix: expected in visible task test
8361983
@Varixo
fix: block visible tasks by its parent and child
21fff80
@Varixo
refactor: rename scheduler-document-position test file
0bf2c30
@Varixo
fix: scheduler rules with QRLs
d3267e0
@Varixo
chore: reenable view transition
846e2b0
@Varixo Varixo force-pushed the v2-scheduler-rewrite branch from ced5b49 to f3dae90 Compare August 16, 2025 13:41
This was linked to issues Aug 18, 2025
[🐞] v2 Signal attribute is not updated during async task #7296
Open
[🐞]Qwik v2: interactive element does not update multiple array items; only one item toggles per click #7795
Open
[🐞] [v2] useTask$ blocks before UI reacts to a change in tracked signal #7416
Open
[🐞] v2 useTask executed for wrong path #7720
Open
@Varixo Varixo force-pushed the v2-scheduler-rewrite branch 5 times, most recently from 539f0c9 to f9ad480 Compare August 18, 2025 18:19
@Varixo Varixo force-pushed the v2-scheduler-rewrite branch from f9ad480 to 9b03622 Compare August 18, 2025 21:05
wmertens
wmertens approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

starters/playwright.config.ts
@@ -24,6 +24,7 @@ const config: PlaywrightTestConfig = {
height: 600,
},
},
fullyParallel: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo 🫶

@Varixo Varixo force-pushed the v2-scheduler-rewrite branch from 9361e42 to cc8a64b Compare August 22, 2025 18:25
@Varixo Varixo force-pushed the v2-scheduler-rewrite branch from e832504 to 82b2c8c Compare August 23, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Status: In progress
Milestone
No milestone
2 participants
@Varixo @wmertens