Skip to content

Commit

Permalink
Improved: added toast when selected column of CSV doesn't matches wit…
Browse files Browse the repository at this point in the history
…h the selected product identifier.(hotwax#394)
  • Loading branch information
R-Sourabh committed Jul 31, 2024
1 parent bee32c4 commit c518782
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"Logging out": "Logging out",
"Logout": "Logout",
"Line status": "Line status",
"Make sure you've reviewed the products and their counts before upload them for review.": "Make sure you've reviewed the products and their counts before upload them for review.",
"Make sure you've reviewed the products and their counts before uploading them for review": "Make sure you've reviewed the products and their counts before uploading them for review",
"No cycle counts found": "No cycle counts found",
"No items found": "No items found",
Expand All @@ -132,6 +131,7 @@
"Please upload a valid csv to continue": "Please upload a valid csv to continue",
"Please contact the administrator.": "Please contact the administrator.",
"Please select a Product identifier": "Please select a Product identifier",
"No product found, please verify your CSV": "No product found, please verify your CSV",
"Please select the column that corresponds to the product identifier": "Please select the column that corresponds to the product identifier",
"Primary": "Primary",
"Primary identifier": "Primary identifier",
Expand Down
2 changes: 1 addition & 1 deletion src/views/CountDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ onIonViewWillLeave(() => {
async function readyForReview() {
const alert = await alertController.create({
header: translate("Submit for review"),
message: translate("Make sure you've reviewed the products and their counts before upload them for review."),
message: translate("Make sure you've reviewed the products and their counts before uploading them for review."),
buttons: [{
text: translate('Cancel'),
role: 'cancel',
Expand Down
1 change: 1 addition & 0 deletions src/views/DraftDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ async function findProductFromIdentifier(payload: any) {
throw resp.data
}
} catch(err) {
showToast(translate("No product found, please verify your CSV"))
logger.error("Failed to add products to count, as some products are not found.", err)
}
}
Expand Down

0 comments on commit c518782

Please sign in to comment.