Skip to content

Conversation

@shun-nakazawa
Copy link
Contributor

表題の通りです。

Ticket

GRDM-37474

@yacchin1205 yacchin1205 marked this pull request as ready for review December 20, 2024 02:02
@yacchin1205 yacchin1205 requested a review from Copilot June 30, 2025 07:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prefixes Mako template filenames with the addon name to avoid caching collisions across different addons.

  • Renamed template includes in user and node settings to myminio_*
  • Updated node_settings_template and user_settings_template paths in apps.py
  • Adjusted README examples to document the new <アドオン名>_* filename convention

Reviewed Changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
StorageAddon/osf.io/addon/templates/*.mako Include calls updated to use myminio_* filenames
StorageAddon/osf.io/addon/apps.py Template path variables updated to myminio_* files
StorageAddon/README.md Documentation updated to show <アドオン名>_* naming
Skelton/addon/apps.py node_settings_template updated to myskelton_*
Skelton/README.md Template name placeholder and links updated
ScreenExpansion/osf.io/addon/apps.py node_settings_template updated to myscreen_*
ScreenExpansion/README.md Template name placeholder updated
Comments suppressed due to low confidence (3)

ScreenExpansion/README.md:51

  • [nitpick] The example uses a placeholder <アドオン名>_node_settings.mako but the actual link below points to myscreen_node_settings.mako. You may want to clarify this placeholder or replace it with the real filename to avoid confusion.
│   └── <アドオン名>_node_settings.mako ... Node設定パネル

StorageAddon/osf.io/addon/templates/myminio_user_settings.mako:6

  • This include references a new template file myminio_credentials_modal.mako. Ensure that the file has been created or renamed in the templates directory; otherwise this include will fail at runtime.
    <%include file="myminio_credentials_modal.mako"/>

Skelton/addon/apps.py:38

  • [nitpick] Consider adding or updating a corresponding user_settings_template entry to match the new naming convention, ensuring consistency with other addons that define both user and node templates.
    node_settings_template = os.path.join(TEMPLATE_PATH, 'myskelton_node_settings.mako')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants