Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ipaPy2 tool suite #468

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Adding the ipaPy2 tool suite #468

wants to merge 24 commits into from

Conversation

hechth
Copy link
Member

@hechth hechth commented Dec 4, 2023

The first stub which doesn't take any parameters at this point is already available and can be used for further implementations. We still need to pass additional parameters to the tool.

@hechth
Copy link
Member Author

hechth commented Dec 4, 2023

@francescodc87 we still need to fill in the owner field in the shed.yml. This can either be your university or we can put in recetox. This means under who's account the tool will be stored in the toolshed, which is used for versioning and also deprecating tools. We currently have all our tools under one organizational account - depending on whether you intend to add more tools it would make sense to add your uni as an owner or us.

@francescodc87
Copy link
Collaborator

@francescodc87 we still need to fill in the owner field in the shed.yml. This can either be your university or we can put in recetox. This means under who's account the tool will be stored in the toolshed, which is used for versioning and also deprecating tools. We currently have all our tools under one organizational account - depending on whether you intend to add more tools it would make sense to add your uni as an owner or us.

@hechth can there be more than one owners? It would make sense to have both University of Liverpool and University of Manchester as owners

@bgruening
Copy link
Collaborator

@francescodc87 this TS owner is just the TS account and should not be used for attribution.

Please use https://docs.galaxyproject.org/en/latest/dev/schema.html#tool-creator-organization to credit your universities.

</requirements>

<command detect_errors="exit_code"><![CDATA[
python3 ${__tool_directory__}/ipapy2_clustering.py --i '${intensity_table}' --o '${output}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 ${__tool_directory__}/ipapy2_clustering.py --i '${intensity_table}' --o '${output}'
python3 '${__tool_directory__}/ipapy2_clustering.py' --i '${intensity_table}' --o '${output}'

@@ -0,0 +1,60 @@
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" python_template_version="3.5" profile="21.05">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" python_template_version="3.5" profile="21.05">
<tool id="ipapy2_clustering" name="ipaPy2 clustering" version="@TOOL_VERSION@+galaxy0" profile="21.05">

Description is missing atm

@@ -0,0 +1,16 @@
import click
import pandas as pd
from ipaPy2 import ipa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we put this small function into a <configfile> or use argparse we could save the click dependency and the additional container.

@hechth
Copy link
Member Author

hechth commented Dec 12, 2023

@francescodc87 the main question is whether you want to maintain the wrappers yourself or not - I guess depending on that we should choose the toolshed owner. As Bjoern said, this is not about representation or credit - this is handled differently using the tags in the XML file.

@francescodc87
Copy link
Collaborator

@hechth I see. Having recetox as owner is fine by me then

@hechth hechth changed the title First draft of clustering wrapper for ipaPy2 Adding the ipaPy2 tool suite Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants