Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchms networking: error message #443

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

The new test currently gives a python Traceback that is hard to read by users. Can this be improved in the wrapper / matchms?

not necessary. also all quotes. and remove linebreaks
this currently only gives a python Traceback that is hard to
read by the user. Can this be improved in the wrapper / matchms?
@bernt-matthias bernt-matthias marked this pull request as draft November 24, 2023 08:06
@bernt-matthias
Copy link
Contributor Author

Please don't merge yet. Would like to see first if we can get a better error message in stderr? Ping @hechth

@hechth
Copy link
Member

hechth commented Aug 15, 2024

@bernt-matthias soo whats up with this here? Anything I can do?

@bernt-matthias
Copy link
Contributor Author

Question is if there should/can be a proper error message instead of the ValueError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants