pkg/mpaland-printf: fix overriding printf with printf_float#21439
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Apr 26, 2025
Merged
pkg/mpaland-printf: fix overriding printf with printf_float#21439maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: pkg
1 task
crasbe
added
Type: bug
crasbe
reviewed
Apr 25, 2025
github-actions
bot
added
Platform: ESP
Enoch247
approved these changes
Apr 26, 2025
Contributor
Enoch247
left a comment
Enoch247
left a comment
There was a problem hiding this comment.
A few nits. I'll let you decide if they are worth addressing or not. Also, I am wondering if some of the patches could be replaced with a glue module for the pkg to improve maintainability, but again, just a nit.
Contributor
|
Nice work! After a squash, this will be ready to merge. |
This makes sure that newlib's printf is correctly overridden by: 1. Adding wrappers for some more obscure printf() variants 2. Forcing a compilation failure when newlib's stdio is still linked in while mpaland-printf is used 3. Not adding `-u _printf_float` to the linker flags when mpaland-printf is used.
When mpaland-printf is used, we do not want to have references to newlib's stdio in the resulting binary.
maribu
force-pushed
the
pkg/mpaland-printf/fix-float
branch
from
083011b to
8e904a0
Compare
Member
Author
|
Thx :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This makes sure that newlib's printf is correctly overridden by:
-u _printf_floatto the linker flags when mpaland-printf is used.Testing procedure
In
masterIn this PR
Issues/PRs references
None