Skip to content

posix/sockets: Prevent deadlock with multiple posix TCP sockets #21784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

posix/sockets: Prevent deadlock with multiple posix TCP sockets #21784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sys/posix/sockets/posix_sockets.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@
switch (s->type) {
case SOCK_STREAM:
new_s = _get_free_socket();
mutex_unlock(&_socket_pool_mutex);
if (new_s == NULL) {
errno = ENFILE;
res = -1;
Expand Down Expand Up @@ -1045,7 +1046,7 @@
}
#if defined(MODULE_SOCK_IP)
if ((res = _sockaddr_to_ep(address, address_len, &ep)) < 0)
return res;

Check warning on line 1049 in sys/posix/sockets/posix_sockets.c

View workflow job for this annotation

GitHub Actions / static-tests 

full block {} expected in the control structure
#endif
switch (s->type) {
#ifdef MODULE_SOCK_IP
Expand Down Expand Up @@ -1158,7 +1159,7 @@
#endif /* ! MODULE_AVR8_COMMON */

if ((uint32_t)tv->tv_sec > max_timeout_secs
|| ((uint32_t)tv->tv_sec == max_timeout_secs && (uint32_t)tv->tv_usec > UINT32_MAX - max_timeout_secs * 1000 * 1000)) {

Check warning on line 1162 in sys/posix/sockets/posix_sockets.c

View workflow job for this annotation

GitHub Actions / static-tests 

line is longer than 100 characters
errno = EDOM;
return -1;
}
Expand Down