c2rust: Export gnrc_netreg_entry_init_pid#69
Merged
Conversation
The function is actually used in riot-wrappers, so not listing it initially was a regression in [66] that went unchecked because none of the standard tests ran GNRC stuff. [66]: #66
Member
Author
|
Taking the liberty to merge a trivial fix without independent review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is actually used in riot-wrappers, so not listing it initially was a regression in 66 that went unchecked because none of the standard tests ran GNRC stuff.
Making the out-of-tree examples ship-shape and thus CI-integratable should help avoid this in the future. (An alternative would be to add better test coverage on GNRC).