Add utils for rendering #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirxEC
approved these changes
Jul 3, 2025
swz-git
requested changes
Jul 3, 2025
Comment on lines
+76
to
+83
| impl From<flat::Vector3> for flat::RenderAnchor { | ||
| fn from(value: flat::Vector3) -> Self { | ||
| Self { | ||
| world: value, | ||
| relative: None, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we should consider something like this instead? It would also remove the need for this
Suggested change
| impl From<flat::Vector3> for flat::RenderAnchor { | |
| fn from(value: flat::Vector3) -> Self { | |
| Self { | |
| world: value, | |
| relative: None, | |
| } | |
| } | |
| } | |
| impl flat::RenderAnchor { | |
| pub fn from_vec(value: impl Into<flat::Vector3>) -> Self { | |
| Self { | |
| world: value.into(), | |
| relative: None, | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
I don't like it because RenderAnchor::from_vec(v) is so much longer than v.into() 😅 And it would be inconsistent with From<CarAnchor> and From<BallAnchor> for relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From<T> for RenderMessageimpls.