Skip to content

Conversation

@kxyk99
Copy link

@kxyk99 kxyk99 commented Jan 22, 2026

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@kxyk99 kxyk99 requested a review from a team January 22, 2026 08:39
@azaidy azaidy requested review from azaidy and vgokhale January 22, 2026 15:19
@azaidy azaidy changed the title support.conv3d.triton.kernel [TRITON] support.conv3d.triton.kernel Jan 22, 2026
@vgokhale
Copy link
Contributor

This kernel is the same as the one here

https://github.com/flagos-ai/FlagGems/blob/18bd83adfead48c30d784e961ddad84d514131e4/src/flag_gems/ops/conv3d.py#L114

which has a different license. Also it is not good for our AI libs to have kernels from other companies.

I would suggest closing this PR and writing a conv 3d kernel from scratch. Thanks.

@kxyk99
Copy link
Author

kxyk99 commented Jan 26, 2026

okay. i will write a new conv implementation.

@kxyk99 kxyk99 force-pushed the support.conv3d.triton.kernels branch 2 times, most recently from 7549438 to c7b39f9 Compare January 29, 2026 09:38
@kxyk99 kxyk99 force-pushed the support.conv3d.triton.kernels branch from c7b39f9 to f9341ce Compare January 29, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants