CI: Optimize and include the gpu count in the tests names #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflow job names to include GPU count/runner labeling and simplifies runner selection logic in CI.
Changes:
- Add explicit
name:fields to multiple workflow jobs to surface GPU/runner info in the GitHub Actions UI. - Convert single-runner jobs to matrix-based jobs (with
include) to standardize labeling and enable future expansion. - Replace dynamic runner selection in
aiter-test.yamlwith explicit matrixincludeentries (and comment out the unuseddefine-runnersjob).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/vllm_benchmark.yaml | Adds job display names, including GPU count for the benchmark job. |
| .github/workflows/triton-test.yaml | Switches to a matrix job to include runner/GPU label in the job name. |
| .github/workflows/sglang_downstream.yaml | Switches to a matrix job to include runner/GPU label in the job name. |
| .github/workflows/aiter-test.yaml | Replaces runner outputs with explicit matrix includes and updates job names to include GPU labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gyohuangxin
force-pushed
the
optimize_test_name
branch
2 times, most recently
from
75d489c to
0dbfa5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/ROCm/frameworks-internal/issues/15296