Skip to content

Conversation

@jeffqjiangNew
Copy link
Contributor

Motivation

This PR fixes the incorrect MD5 results when user crop is enabled.

Technical Details

  • When the user cropping is enabled, the cropping rect needs to be sent to the output surface info struct, which is used by the MD5 calculation.

Test Plan

  • Run video decode sample app with cropping, output dump and MD5 enabled. Use an MD5 generation app to calculate the MD5 digest of the output YUV file, and compare to the MD5 output from the sample app.

Test Result

  • The two MD5 values should match.

Submission Checklist

 - When the user cropping is enabled, the cropping rect needs to be sent to the output surface info struct, which is used by the MD5 calculation.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect MD5 hash calculations when user cropping is enabled in the video decoder by ensuring the cropping rectangle is properly propagated to the output surface information structure.

  • Added conditional logic to use crop_rect_ instead of disp_rect_ when user cropping is active
  • Applied the fix in both HandleVideoSequence and ReconfigureDecoder functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix ci:precheckin run mainline precheckin CI job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants