Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Navi3x/Navi4x hardware to the weekly run #1768

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dorde-antic
Copy link
Contributor

Do weekly tuning on Navi3x/Navi4x and use those perfDBs for nightly performance runs

Resolves #1727

@dorde-antic dorde-antic requested a review from causten as a code owner March 7, 2025 12:08
@dorde-antic dorde-antic requested a review from umangyadav March 7, 2025 16:19
@@ -685,7 +688,7 @@ pipeline {
axes {
axis {
name 'ARCH'
values 'gfx908', 'gfx90a', 'gfx1030'
values 'gfx908', 'gfx90a', 'gfx1030', 'gfx1100', 'gfx1101', 'gfx1201'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gfx1100 and gfx1101 both are Navi3x based cards. I don't think we need to run on both of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to use same label later in this stage for Navi3x:

values 'gfx908', 'gfx90a', 'gfx942', 'gfx1030', 'gfx1101'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umangyadav regarding gfx1100 and gfx1101, I talked with Stefan so we thought that it would be good to do it on both and see which is more stable.
But if you think it's better, we can run it only on one of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to do it on both and see which is more stable.

To me it seems we are not correctly making use of the Jenkins Tuning and Nightly Runs as of today. i.e. we are not really analyzing perf results on daily basis.

Therefore it seems to me we are better off keeping just one of the Navi3x on the CI right now. otherwise we increase likelihood of failing weekly CI due to random errors and it will cause more problems.

@umangyadav
Copy link
Member

Can you also add Navi3x to parameterSweeps stage ?

values 'mfma', 'vanilla', 'navi21'
?

@@ -812,7 +814,7 @@ pipeline {
axes {
axis {
name 'CHIP'
values 'gfx908', 'gfx90a', 'gfx1030', 'gfx1101'
values 'gfx908', 'gfx90a', 'gfx1030', 'gfx1100', 'gfx1201'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you trigger nightly and weekly tuning runs manually on this branch and see if it is tuning and generating perf reports ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants