Remove hasValidChip() from ConvGenerator #1771
Conversation
| if (checkChip && failed(hasValidChip())) { | ||
| return failure(); | ||
| } | ||
| // if (checkChip && failed(hasValidChip())) { |
There was a problem hiding this comment.
can we instead use AmdArchDb.cpp file to keep this validity check instead of removing it ?
There was a problem hiding this comment.
I think this is only used for miopen integration. Otherwise, checkChip is always false. Let's remove checkChip flag and other non used files
There was a problem hiding this comment.
this is only used for miopen integration.
Okay. Looks like another maintenance overhead. We should check if MIOpen requires rocMLIR or not.
There was a problem hiding this comment.
please remove checkChip and used files for miopen integration.
EDIT: Actually I think MLIRRockThin is needed for get_fat_library_deps_list.pl. So let's remove at least checkChip in isApplicable() and hasValidChip()
Ideally, we would get rid of MLIRRockThin and figure out dependencies using some other way? But let's do that in another ticket.
dorde-antic
requested review from
stefankoncarevic,
djramic and
mirza-halilcevic
There was a problem hiding this comment.
please remove "bool checkChip = true" in isApplicable
| @@ -138,10 +138,11 @@ class ConvGenerator { | |||
| std::replace(targetLayout.begin(), targetLayout.end(), 'y', '0'); | |||
| std::replace(targetLayout.begin(), targetLayout.end(), 'x', '1'); | |||
| std::replace(targetLayout.begin(), targetLayout.end(), 'h', '0'); | |||
| std::replace(targetLayout.begin(), targetLayout.end(), 'w', '1'); | |||
| std::replace(targetLayout.begin(), targetLayout.end() P, 'w', '1'); | |||
Remove hasValidChip() and checkChip. Modify isApplicable() function.
Resolves #1753