Enable RBE for builds and test #151
Conversation
charleshofer
requested review from
JehandadKhan,
alekstheod and
gulsumgudukbay
charleshofer
force-pushed
the
add-rbe-configs
branch
14 times, most recently
from
e611e5f to
54661a1
Compare
| exec_properties = { | ||
| "container-image": "docker://rocm/tensorflow-build@sha256:7cd444ac48657fee2f5087fbda7766266704d3f8fb2299f681952ae4eabed060", | ||
| "OSFamily": "Linux", | ||
| "Pool": "linux_x64_gpu", |
There was a problem hiding this comment.
Please remove this Pool name. It seems in our setup we do not need it. It should be default then engflow will redirect test actions automatically into the gpu pool. Also we could remove the gpu suffix.
There was a problem hiding this comment.
That requires this change, correct? openxla/xla#32954 How do you plan on getting that change into a branch that we can actually use? I'm 90% sure that using openxla/xla's main branch is going to bust our master branch. I would say to just land it in rocm-jaxlib-v0.7.1, but we really shouldn't be putting anything other than bug fixes in there.
There was a problem hiding this comment.
I thought we could merge these kind of things into 0.7.1. It is infrastructure change not really affecting functionality.
There was a problem hiding this comment.
Not a fan, but I guess that's fine for now. It pollutes a branch that should be frozen. Really wish you guys had separate downstream branches for development and release.
There was a problem hiding this comment.
I'll update my PR once that's in 0.7.1. I don't want to merge a change to our master that's going to bust our build because the RBE cluster and it's pools are screwy.
charleshofer
force-pushed
the
add-rbe-configs
branch
2 times, most recently
from
0de3314 to
9645465
Compare
charleshofer
force-pushed
the
add-rbe-configs
branch
from
9645465 to
75f5f9a
Compare
Motivation
Add the proper Bazel configuration to do remote builds with Bazel's RBE feature. This should greatly improve build times in CI.
Test Plan
Ran the
build/ci_build.pyscript locally and confirmed that it'll produce wheels with ROCm 7