-
Notifications
You must be signed in to change notification settings - Fork 101
[rocprofiler-sdk] Fix fmt::join build errors
#2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- remedy use of fmt::join without include <fmt/ranges.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes build errors related to the use of fmt::join by adding the required #include <fmt/ranges.h> header. The fmt::join function requires this header to be explicitly included for proper compilation.
Key Changes:
- Added
#include <fmt/ranges.h>in all source files that usefmt::join - Standardized include format from relative to angle brackets in one file for consistency
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-sdk/source/lib/tests/common/parse.cpp | Added fmt/ranges.h include for fmt::join usage |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/queue.cpp | Added both fmt/format.h and fmt/ranges.h includes |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp | Added fmt/format.h and fmt/ranges.h includes |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/details/format.hpp | Standardized include format from relative to angle brackets |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/dimension.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/device_counting.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/python/rocpd/source/sql_generator.hpp | Added fmt/format.h and fmt/ranges.h includes |
| projects/rocprofiler-sdk/source/lib/python/rocpd/source/serialization/sql.cpp | Added fmt/format.h and fmt/ranges.h includes |
| projects/rocprofiler-sdk/source/lib/python/rocpd/libpyrocpd.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/output/sql/common.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/output/generateStats.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/output/generateRocpd.cpp | Added fmt/ranges.h include |
| projects/rocprofiler-sdk/source/lib/common/logging.cpp | Added fmt/ranges.h include |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
fmt errors are fixed, but noticed another error now in the CI run (https://github.com/ROCm/rocm-systems/actions/runs/20752803257/job/59586526364?pr=2505): |
|
Opened #2537 to check for this |
Motivation
fmt::joinwithout#include <fmt/ranges.h>Technical Details
fmt::joinJIRA ID
Test Plan
N/A
Test Result
N/A
Submission Checklist