Skip to content

Conversation

@jrmadsen
Copy link
Contributor

@jrmadsen jrmadsen commented Jan 6, 2026

Motivation

  • remedy use of fmt::join without #include <fmt/ranges.h>

Technical Details

  • adding include in every file using fmt::join

JIRA ID

Test Plan

N/A

Test Result

N/A

Submission Checklist

- remedy use of fmt::join without include <fmt/ranges.h>
Copilot AI review requested due to automatic review settings January 6, 2026 15:19
@jrmadsen jrmadsen requested review from a team as code owners January 6, 2026 15:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes build errors related to the use of fmt::join by adding the required #include <fmt/ranges.h> header. The fmt::join function requires this header to be explicitly included for proper compilation.

Key Changes:

  • Added #include <fmt/ranges.h> in all source files that use fmt::join
  • Standardized include format from relative to angle brackets in one file for consistency

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/rocprofiler-sdk/source/lib/tests/common/parse.cpp Added fmt/ranges.h include for fmt::join usage
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/queue.cpp Added both fmt/format.h and fmt/ranges.h includes
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp Added fmt/format.h and fmt/ranges.h includes
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/details/format.hpp Standardized include format from relative to angle brackets
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/dimension.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/device_counting.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/python/rocpd/source/sql_generator.hpp Added fmt/format.h and fmt/ranges.h includes
projects/rocprofiler-sdk/source/lib/python/rocpd/source/serialization/sql.cpp Added fmt/format.h and fmt/ranges.h includes
projects/rocprofiler-sdk/source/lib/python/rocpd/libpyrocpd.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/output/sql/common.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/output/generateStats.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/output/generateRocpd.cpp Added fmt/ranges.h include
projects/rocprofiler-sdk/source/lib/common/logging.cpp Added fmt/ranges.h include

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbonnell-amd
Copy link
Collaborator

fmt errors are fixed, but noticed another error now in the CI run (https://github.com/ROCm/rocm-systems/actions/runs/20752803257/job/59586526364?pr=2505):

[ 45%] Building CXX object source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/external_correlation.cpp.o
/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/metrics.hpp:104:6: error: no template named 'shared_ptr' in namespace 'std' [clang-diagnostic-error]
  104 | std::shared_ptr&lt;const counter_metrics_t&gt;
      | ~~~~~^

@MythreyaK
Copy link
Contributor

Opened #2537 to check for this shared_ptr issue. If CI works on that then it can be merged into this PR I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants