SWDEV-569319 Fix dangling reference warning #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghoshamd
requested review from
cfreeamd,
dayatsin-amd and
kentrussell
as code owners
ypapadop-amd
requested changes
Jan 6, 2026
projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_hsa_code.hpp
Outdated
Show resolved
Hide resolved
ypapadop-amd
approved these changes
Jan 6, 2026
Contributor
ypapadop-amd
left a comment
ypapadop-amd
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
dayatsin-amd
approved these changes
Jan 7, 2026
systems-assistant bot
pushed a commit
to ROCm/ROCR-Runtime
that referenced
this pull request
Jan 13, 2026
* SWDEV-569319 Fix dangling reference warning * fix nullptr warning * use emplace * return regular pointer [rocm-systems] ROCm/rocm-systems#2509 (commit d2a1fc9)
ggottipa-amd
pushed a commit
that referenced
this pull request
Jan 20, 2026
* SWDEV-569319 Fix dangling reference warning * fix nullptr warning * use emplace * return regular pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist