SWDEV-1 Fix vulkan test build failure in Windows #2512
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows build failure in the Vulkan interop tests by preventing Windows.h from defining min/max macros that conflict with C++ standard library functions.
- Adds
NOMINMAXpreprocessor definition before including Windows headers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gandryey
approved these changes
Jan 16, 2026
TomSang
force-pushed
the
users/taosang/SWDEV-1-fix-vulkan-build-in-windows
branch
from
d0323de to
e4b2e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix vulkan test build failure in Windows
Technical Details
min, max conflicts with windows definition
JIRA ID
Test Plan
pass vulkan test
Test Result
passed
Submission Checklist