clr: Fix segfault when running kernel compiled for different arch #2514
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a segfault that occurs when attempting to run a kernel compiled for a different architecture. The fix adds validation to check if the kernel pointer is null before attempting to use it, returning an appropriate error instead of crashing.
Key Changes:
- Added null pointer check for kernel object in
ihipLaunchKernel_validate - Returns
hipErrorInvalidValuewhen an invalid kernel is detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manocharahul
force-pushed
the
amd/dev/rmanocha/kernel-segfault
branch
from
d0b7273 to
f6f4adb
Compare
manocharahul
force-pushed
the
amd/dev/rmanocha/kernel-segfault
branch
from
9ca5901 to
e881d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
#2484
Test Plan
Test Result
Submission Checklist