updated 'amdsmi list --cpu all' command, which returns NA #2519
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the amdsmi list command to handle CPU arguments by returning "NA" when --cpu is specified, since the list command is designed only for GPU information.
- Added a
cpuparameter to thelistmethod signature - Implemented early return with "NA" output when CPU argument is detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
234
to
235
| print("NA") | ||
| return |
There was a problem hiding this comment.
Using print() directly bypasses the logger framework that is consistently used throughout the codebase. This breaks output formatting for JSON and CSV formats, and doesn't respect the --file output destination. Consider using self.logger to handle the output properly, similar to how other commands return "N/A" values.
Suggested change
| print("NA") | |
| return | |
| self.logger.info("NA") | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated "amdsmi list --cpu all" command, which will return NA.