[rdc][rocprofiler-sdk][7.2 backport] Add PTL unified control and fix counter ID lookup #2527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds PTL (Peak Tops Limiter) control support for MI300 GPUs and fixes a counter ID lookup issue in RDC. rocprofiler-sdk changes: - Add KFD_IOC_PROFILER_PTL_CONTROL ioctl operation and kfd_ioctl_ptl_control struct to kfd_ioctl.h for PTL enable/disable control - Add ptl_control_supported(), counter_collection_ptl_disable(), and counter_collection_ptl_enable() functions to ioctl.cpp/hpp - Enable counter_collection_device_unlock() function (was commented out) - Integrate PTL disable in configure_dispatch() for dispatch counter collection - Add PTL disable on start and PTL enable on stop for device counting service in device_counting.cpp RDC changes: - Fix counter ID lookup by using base metric ID (lower 16 bits) instead of full handle which includes dimension encoding - Use global thread-safe counter name map for proper ID-to-name resolution
Signed-off-by: Galantsev, Dmitrii <[email protected]>
Signed-off-by: Galantsev, Dmitrii <[email protected]>
The PTL control failure is expected on older kernels/hardware that don't support this feature, so INFO is more appropriate than WARNING. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
adam360x
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #2469 to release/rocm-rel-7.2
This change adds PTL (Peak Tops Limiter) control support for MI300 GPUs and fixes a counter ID lookup issue in RDC.
rocprofiler-sdk changes:
RDC changes:
Test plan
Cherry-picked from: #2469
🤖 Generated with Claude Code