[rocprofiler-compute] Update .config_hashes.json #2530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent PR there was an update to the delta files and gfx950 1100 yaml after the hash_manager was run, and was not regenerated in the PR review. Pre-commit is complaining now that the delta file md5s don't match. Signed-off-by: Carrie Fallows <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the .config_hashes.json file to fix mismatched MD5 hash values. The delta_hash values for multiple GPU architectures (gfx908, gfx90a, gfx940, gfx941, gfx942, gfx950) were out of sync with the actual delta file contents, and one configuration file hash for gfx950 was also updated.
Key Changes:
- Updated delta_hash values for six GPU architectures to match their corresponding delta files
- Updated hash for gfx950's 1100_compute_units_compute_pipeline.yaml configuration file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cfallows-amd
changed the title
Contributor
|
Verified that no pre-commit check fails |
vedithal-amd
approved these changes
Jan 8, 2026
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-compute
that referenced
this pull request
Jan 8, 2026
config_hashes json had mismatched md5s for the delta_hash values, regenerated the file with the existing files in develop branch. Signed-off-by: Carrie Fallows <[email protected]> [rocm-systems] ROCm/rocm-systems#2530 (commit ae1abe4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
config_hashes json had mismatched md5s for the delta_hash values.
Technical Details
In a recent PR there was an update to the delta files and gfx950 1100 yaml after the hash_manager was run, and was not regenerated in the PR review. Pre-commit is complaining now that the delta file md5s don't match.
JIRA ID
Test Plan
Manually generated md5s of the gfx950_diff.yaml in each config_delta dir using
md5sum -bin cmd line, then compared against the config_hashes.json file before and after running hash_manager commands to ensure they match.Test Result
Verified that no pre-commit check fails
Submission Checklist