Skip to content

Conversation

@vedithal-amd
Copy link
Contributor

@vedithal-amd vedithal-amd commented Jan 8, 2026

Motivation

  • Eiminate the dependency on kaleido and plotly_get_chrome by moving towards plotly native HTML image roofline chart generation

  • Update help message, documentation and CHANGELOG to advertise this change

Technical Details

PDF generation using plotly requires kaleido and google chrome browser which are dependencies which we want to eliminate.

Switch to plotly native HTML generation to generate HTML files for roofline charts. Example is attached below

empirRoof_gpu-0_FP32.html

JIRA ID

Test Plan

Test Result

Ensure standalone roofline works and all roofline tests work

Submission Checklist

* Eiminate the dependency on kaleido and plotly_get_chrome by moving
  towards plotly native HTML image roofline chart generation
Copilot AI review requested due to automatic review settings January 8, 2026 16:38
@vedithal-amd vedithal-amd requested review from a team and prbasyal-amd as code owners January 8, 2026 16:38
@github-actions github-actions bot added documentation Improvements or additions to documentation project: rocprofiler-compute labels Jan 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request eliminates dependencies on kaleido and Chrome by switching from PDF to HTML generation for roofline charts in standalone mode. The change leverages Plotly's native HTML export functionality instead of the image export that required external dependencies.

Key changes:

  • Replaced write_image() calls with write_html() for roofline chart generation
  • Updated all test files to expect .html files instead of .pdf files
  • Comprehensively updated documentation to reflect HTML output format

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/roofline.py Replaced write_image() with write_html() for standalone roofline chart generation, removed width/height parameters
src/utils/roofline_calc.py Updated comment from "PDF" to "HTML"
src/argparser.py Updated help text for --roofline-data-type option to reference HTML instead of PDF
tests/test_utils.py Updated file extension check from .pdf to .html
tests/test_profile_general.py Updated all test expectations, assertions, and comments to reference HTML files instead of PDF files
docs/how-to/profile/mode.rst Comprehensively updated documentation to reference HTML output format
docs/how-to/analyze/standalone-gui.rst Updated roofline analysis documentation to reference HTML
README.md Removed note about libnss3.so dependency requirement for PDF generation
CHANGELOG.md Added entry documenting the change from PDF to HTML output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@cfallows-amd cfallows-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for rocprof-compute end of things. We are waiting for some HPC team feedback as well for the changes in outlook/teams to be addressed as needed.

@vedithal-amd vedithal-amd merged commit 51ba3c3 into develop Jan 9, 2026
28 checks passed
@vedithal-amd vedithal-amd deleted the users/vedithal/rocprofiler-compute-fix-roofline branch January 9, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants