Skip to content

Users/mkuriche/rocprofiler sdk fmt build fix memory header #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonnell-amd merged 8 commits into from
Jan 12, 2026
Merged

Users/mkuriche/rocprofiler sdk fmt build fix memory header #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc2bd75
[rocprofiler-sdk] Fix fmt::join build errors
jrmadsen Jan 6, 2026
d60a349
include memory header
MythreyaK Jan 8, 2026
3f116ec
Disable FMT build for SDK CI
jbonnell-amd Jan 8, 2026
7bacaab
Add -DROCPROFILER_BUILD_FMT=OFF to sanitizer steps
jbonnell-amd Jan 9, 2026
db7911c
Add temporary workaround for rccl.h issue
jbonnell-amd Jan 9, 2026
9c1ea2a
Add ROCPROFILER_INTERNAL_RCCL_API_TRACE to SDK CI builds
jbonnell-amd Jan 9, 2026
c006722
disable clang-tidy for vendored includes
MythreyaK Jan 9, 2026
5b57069
Merge branch 'develop' into users/mkuriche/rocprofiler-sdk-fmt-build-…
jbonnell-amd Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/rocprofiler-sdk-continuous_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ jobs:
${{ matrix.system.ci-flags }} -- \
-DROCPROFILER_DEP_ROCMCORE=ON \
-DROCPROFILER_BUILD_DOCS=OFF \
-DROCPROFILER_BUILD_FMT=OFF \
-DROCPROFILER_INTERNAL_RCCL_API_TRACE=ON \
-DCMAKE_BUILD_TYPE=${{ matrix.system.build-type }} \
-DCMAKE_INSTALL_PREFIX=/opt/rocprofiler-sdk \
-DCPACK_GENERATOR='DEB;RPM;TGZ' \
Expand Down Expand Up @@ -632,6 +634,8 @@ jobs:
-- \
-DROCPROFILER_DEP_ROCMCORE=ON \
-DROCPROFILER_BUILD_DOCS=OFF \
-DROCPROFILER_BUILD_FMT=OFF \
-DROCPROFILER_INTERNAL_RCCL_API_TRACE=ON \
-DCMAKE_BUILD_TYPE=${{ matrix.system.build-type }} \
-DCMAKE_PREFIX_PATH='${{ env.ROCM_PATH }};${{ env.ROCM_PATH }}/llvm' \
-DPython3_EXECUTABLE=$(which python3) \
Expand Down Expand Up @@ -846,6 +850,8 @@ jobs:
--memcheck ${{ matrix.system.sanitizer }}
--run-attempt ${{ github.run_attempt }}
--
-DROCPROFILER_BUILD_FMT=OFF \
-DROCPROFILER_INTERNAL_RCCL_API_TRACE=ON \
-DCMAKE_BUILD_TYPE=${{ matrix.system.build-type }}
-DCMAKE_INSTALL_PREFIX="${{ env.ROCM_PATH }}"
-DCMAKE_PREFIX_PATH='${{ env.ROCM_PATH }};${{ env.ROCM_PATH }}/llvm'
Expand Down
4 changes: 3 additions & 1 deletion projects/rocprofiler-sdk/cmake/rocprofiler_linting.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ macro(ROCPROFILER_ACTIVATE_CLANG_TIDY)
"path to clang-tidy executable")

set(CMAKE_CXX_CLANG_TIDY
${ROCPROFILER_CLANG_TIDY_EXE} -header-filter=${PROJECT_SOURCE_DIR}/source/.*
${ROCPROFILER_CLANG_TIDY_EXE}
-header-filter=${PROJECT_SOURCE_DIR}/source/.*
--exclude-header-filter=${PROJECT_SOURCE_DIR}/source/include/rocprofiler-sdk/rccl/details/.*
--warnings-as-errors=*,-misc-header-include-cycle)

# Create a preprocessor definition that depends on .clang-tidy content so the
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/common/logging.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "lib/common/filesystem.hpp"

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <glog/logging.h>
#include <glog/vlog_is_on.h>

Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/output/generateRocpd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
#include <rocprofiler-sdk-rocpd/types.h>

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <sqlite3.h>
#include <unistd.h>

Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/output/generateStats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <rocprofiler-sdk/marker/api_id.h>

#include <fmt/format.h>
#include <fmt/ranges.h>

#include <unistd.h>
#include <cstdint>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/output/sql/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <rocprofiler-sdk/cxx/operators.hpp>

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <sqlite3.h>

#include <iomanip>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/python/rocpd/libpyrocpd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
#include <rocprofiler-sdk-rocpd/sql.h>

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <gotcha/gotcha.h>
#include <pybind11/detail/common.h>
#include <pybind11/pybind11.h>
Expand Down
3 changes: 3 additions & 0 deletions projects/rocprofiler-sdk/source/lib/python/rocpd/source/serialization/sql.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
#include "lib/python/rocpd/source/serialization/sql.hpp"
#include "lib/output/sql/common.hpp"

#include <fmt/format.h>
#include <fmt/ranges.h>

namespace cereal
{
SQLite3InputArchive::SQLite3InputArchive(sqlite3* conn,
Expand Down
2 changes: 2 additions & 0 deletions projects/rocprofiler-sdk/source/lib/python/rocpd/source/sql_generator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
#include "lib/output/generator.hpp"
#include "lib/output/sql/common.hpp"

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <sqlite3.h>

#include <chrono>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
#include <rocprofiler-sdk/cxx/operators.hpp>

#include <fmt/core.h>
#include <fmt/ranges.h>

#include <time.h>
#include <unistd.h>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/metrics.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <hsa/hsa_ven_amd_aqlprofile.h>

#include <cstdint>
#include <memory>
#include <optional>
#include <string>
#include <unordered_map>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/device_counting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <rocprofiler-sdk/rocprofiler.h>

#include <fmt/core.h>
#include <fmt/ranges.h>
#include <gtest/gtest.h>
#include <hsa/hsa.h>
#include <hsa/hsa_api_trace.h>
Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/tests/dimension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <rocprofiler-sdk/rocprofiler.h>

#include <fmt/core.h>
#include <fmt/ranges.h>
#include <gtest/gtest.h>
#include <hsa/hsa.h>
#include <hsa/hsa_api_trace.h>
Expand Down
4 changes: 2 additions & 2 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/details/format.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
#include <hip/hip_deprecated.h>
#include <hip/hip_version.h>

#include "fmt/core.h"
#include "fmt/ranges.h"
#include <fmt/core.h>
#include <fmt/ranges.h>

#define ROCP_SDK_HIP_FORMATTER(TYPE, ...) \
template <> \
Expand Down
3 changes: 3 additions & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/details/fmt.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@

#include "lib/rocprofiler-sdk/hsa/queue.hpp"

#include <fmt/format.h>
#include <fmt/ranges.h>

namespace fmt
{
template <>
Expand Down
2 changes: 2 additions & 0 deletions projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
#include <rocprofiler-sdk/external_correlation.h>
#include <rocprofiler-sdk/fwd.h>

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <hsa/hsa.h>
#include <hsa/hsa_ext_amd.h>

Expand Down
1 change: 1 addition & 0 deletions projects/rocprofiler-sdk/source/lib/tests/common/parse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <rocprofiler-sdk/cxx/details/tokenize.hpp>

#include <fmt/format.h>
#include <fmt/ranges.h>
#include <gtest/gtest.h>

#include <cstddef>
Expand Down
Loading