Skip to content

Update SDK Dockerfile.ci for Ubuntu #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbonnell-amd merged 9 commits into from
Jan 9, 2026
Merged

Update SDK Dockerfile.ci for Ubuntu #2539

jbonnell-amd merged 9 commits into from
Jan 9, 2026

Conversation

@jbonnell-amd
Copy link
Collaborator

@jbonnell-amd jbonnell-amd commented Jan 8, 2026 •
edited
Loading

Motivation

  • SDK CI workflows in Ubuntu were failing due to git errors when trying to generate submodule cache
  • This was due to using an older version of Git on Ubuntu workflows

Technical Details

  • Remove duplicate git install in Dockerfile.ci on Ubuntu workflow that was ran before grabbing the git repository to get newer versions
  • Ubuntu now installs git version 2.52.0, updated RHEL and SLES to use this version as well (instead of 2.51.0)

JIRA ID

Test Plan

  • Ensure Ubuntu/RHEL/SLES dockers all contain git version 2.52.0
  • Workflow for Ubuntu passes the generate submodule cache step

Test Result

  • Dockers have correct git versions, workflow for Ubuntu passes the generate submodule cache step

Submission Checklist

@github-actions github-actions bot added the github actions Pull requests that update GitHub Actions code label Jan 8, 2026
@jbonnell-amd jbonnell-amd changed the title Add verbose output for submods step Update SDK Dockerfile.ci for Ubuntu Jan 8, 2026
@jbonnell-amd jbonnell-amd marked this pull request as ready for review January 8, 2026 20:37
@jbonnell-amd jbonnell-amd requested review from a team as code owners January 8, 2026 20:37
@jbonnell-amd jbonnell-amd merged commit 788bcdd into develop Jan 9, 2026
43 of 55 checks passed
@jbonnell-amd jbonnell-amd deleted the users/jbonnell-amd/submodule-cache branch January 9, 2026 17:10
systems-assistant bot pushed a commit to ROCm/rocprofiler-sdk that referenced this pull request Jan 9, 2026
@jbonnell-amd @systems-assistant
Update SDK Dockerfile.ci for Ubuntu
18f7437 
* Add verbose output for submods step

* Remove git config setting

* Determine git version

* Try different git install

* Update Dockerfile.ci

* Revert git location in Ubuntu jobs

* Update RHEL and SLES sections to use 2.52 as well

* Add git --version to each step, fix typo in SLES Docker
[rocm-systems] ROCm/rocm-systems#2539 (commit 788bcdd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammarwa ammarwa ammarwa approved these changes

@dgaliffiAMD dgaliffiAMD dgaliffiAMD approved these changes

@venkat1361 venkat1361 Awaiting requested review from venkat1361

Assignees

No one assigned

Labels

github actions Pull requests that update GitHub Actions code organization: ROCm project: rocprofiler-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbonnell-amd @ammarwa @dgaliffiAMD