Revert "fix: prevent double-free crash during process exit in amd-smi… #2640
+7
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous workaround that prevented double-free crashes during process exit when using AMD SMI libraries. The workaround is no longer needed as the root cause has been fixed in the underlying amd-smi and rocm-smi-lib libraries.
Changes:
- Removes AMD SMI-specific exit handling logic that forced early finalization and
_exit()calls - Restores proper AMD SMI shutdown sequence with conditional cleanup
- Removes library unload prevention mechanisms that were part of the workaround
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| exit_gotcha.cpp | Removes AMD SMI-specific exit handling workaround and cleans up unused includes |
| amd_smi.cpp | Restores conditional shutdown logic with proper amdsmi_shut_down() call |
| gpu.cpp | Removes library unload prevention function and its invocation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/rocprofiler-systems/source/lib/rocprof-sys/library/components/exit_gotcha.cpp
Show resolved
Hide resolved
1 task
habajpai-amd
force-pushed
the
users/habajpai-amd/revert-doublefree-workaound-pr-2213
branch
from
76b113c to
64ec8ab
Compare
mradosav-amd
approved these changes
Jan 16, 2026
habajpai-amd
force-pushed
the
users/habajpai-amd/revert-doublefree-workaound-pr-2213
branch
from
64ec8ab to
8bc4163
Compare
habajpai-amd
force-pushed
the
users/habajpai-amd/revert-doublefree-workaound-pr-2213
branch
from
8bc4163 to
452891a
Compare
dgaliffiAMD
approved these changes
Jan 16, 2026
dgaliffiAMD
deleted the
users/habajpai-amd/revert-doublefree-workaound-pr-2213
branch
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Jan 16, 2026
amd-smi (#2213)" (#2640)
This reverts commit 7b00d3a89b43bdd084454843db0c8412f44414dd.
The workaround is no longer needed - root cause fixed in:
- rocm-smi-lib (PR #2531): Made devInfoTypesStrings file-local static
- amdsmi (PR #2575): Added visibility("hidden") attribute
[rocm-systems] ROCm/rocm-systems#2640 (commit b53c996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#2213)"
This reverts commit 7b00d3a.
The workaround is no longer needed - root cause fixed in amd-smi and rocm-smi-lib.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist