Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(work codes): add ACUM ID #805

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix(work codes): add ACUM ID #805

merged 1 commit into from
Mar 10, 2025

Conversation

dvirtz
Copy link
Contributor

@dvirtz dvirtz commented Dec 19, 2024

fixes ACUM ID format #804

kellnerd
kellnerd approved these changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust your expertise here.
Let me know if the version bump from the other PR is sufficient to also update this @require'd file.

@kellnerd
Copy link
Collaborator

kellnerd commented Mar 9, 2025

Hmm, I can't merge this because some checks are not running... As we have to wait/resolve this anyway, you could push a commit which updates the version in the require URLs of the two scripts which are using this library.

@dvirtz
Copy link
Contributor Author

dvirtz commented Mar 9, 2025

Actually, since opening this PR I learned that ACUM can also have letters in their identifiers as shown by dvirtz/musicbrainz-scripts#56.
I updated the regex and versions.

@kellnerd
Copy link
Collaborator

Thank you, with your last push the button to approve CI workflows finally reappeared.
Can you also bump the versions of the two userscripts themselves, please, otherwise nobody will get notified about the updated library. You probably have to rebase on main to avoid a merge conflict because of yesterday's release.

@dvirtz
fix(work codes): add ACUM ID
26d46a5 
fixes ACUM ID format ROpdebee#804
update script version
@dvirtz
Copy link
Contributor Author

dvirtz commented Mar 10, 2025

Done

@kellnerd kellnerd merged commit df9ef21 into ROpdebee:main Mar 10, 2025
9 checks passed
@kellnerd kellnerd linked an issue Mar 10, 2025 that may be closed by this pull request
ACUM ID format #804
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellnerd kellnerd kellnerd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working deploy:skipped mb_bulk_copy_work_codes mb_validate_work_codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACUM ID format
2 participants
@dvirtz @kellnerd