Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(work codes): Update ISWC table selector on https://iswcnet.cisac.org/search #808

Merged
merged 1 commit into from
Mar 9, 2025
Merged

fix(work codes): Update ISWC table selector on https://iswcnet.cisac.org/search #808

merged 1 commit into from
Mar 9, 2025
+3 −3

Conversation

Lioncat6
Copy link
Contributor

Replaced table field selector PREFERRED_ISWC_FIELD with ISWC_FIELD

image

@Lioncat6
fix(Bulk copy-paste work codes): table selector on https://iswcnet.ci…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
ac4f167 
…sac.org/search
@Lioncat6 Lioncat6 mentioned this pull request Feb 14, 2025
Closed
@dvirtz
Copy link
Contributor

dvirtz commented Mar 9, 2025

@kellnerd is this something you can merge?

kellnerd
kellnerd approved these changes Mar 9, 2025
View reviewed changes
Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can.
As I am not using this script myself, I am approving the PR under the assumption that CISAC no longer provides alternative ("archived") ISWC values.
Seems to work for me now, thank you @Lioncat6!

@kellnerd kellnerd added bug Something isn't working mb_bulk_copy_work_codes labels Mar 9, 2025
@kellnerd kellnerd changed the title fix(Bulk copy-paste work codes): table selector on https://iswcnet.cisac.org/search fix(work codes): Update ISWC table selector on https://iswcnet.cisac.org/search Mar 9, 2025
@kellnerd kellnerd merged commit 77e4cbc into ROpdebee:main Mar 9, 2025
11 checks passed
@kellnerd kellnerd linked an issue Mar 9, 2025 that may be closed by this pull request
Bulk copy-paste work codes: Uncaught TypeError #806
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellnerd kellnerd

Assignees
No one assigned
Labels
bug Something isn't working deploy:skipped mb_bulk_copy_work_codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk copy-paste work codes: Uncaught TypeError
3 participants
@Lioncat6 @dvirtz @kellnerd