feat(ecau): Seed cover art from Harmony release actions pages #810
Conversation
|
I've compiled a version with these changes that you can test here: |
- Create index.tsx Add harmony seeder - Update index.ts HarmonySeeder - Update meta.ts Added harmony
kellnerd
changed the title
|
/deploy-preview Edit: Unfortunately the preview command is still broken (#801), I was hoping it might work again since codecov is currently working again. |
There was a problem hiding this comment.
Thank you!
I've fixed a few things which were causing CI checks to fail:
- Reworded your commit messages to follow https://www.conventionalcommits.org/en/v1.0.0/ and squashed your first three commits.
- Stylistic changes to make eslint happy.
Additionally I've turned the clickable div containers into proper HTML links, which the users can open in the same or a new tab, as they prefer. This also gives them a blue background and the appropriate cursor, so the injected CSS is no longer necessary.
And finally I'm manipulating the origin URL to point to a cached version of the Harmony release actions page (leveraging an undocumented feature 😏).
Two potential improvements remain, but they can be done in subsequent PRs:
- Display image dimensions. We can probably reuse the entire
atisket/dimensions.tsmodule for that. - Seed the release URL instead of the image URL. This would allow ECAU to grab multiple images for supported providers (currently: Bandcamp) and we can remove the assumption that the image is a front cover (which is not always true, Bandcamp again).
- Resolve linter warnings - Harmony release actions are always for one specific release - Drop iTunes image URL hack, ECAU already uses Image Max URL
feat(ecau): Seed cover art from Harmony release actions pages (#810)
|
🚀 Released 1 new userscript version(s):
|
|
Amazing! |
Added support for harmony.pulsewidth.org.uk to the Enhanced Cover Art Uploads userscript. This allows users to easily add cover art from the Harmony importer to MusicBrainz releases with a single click, similar to the existing a-tisket integration.