CI: Improve PR HTML generator #4792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also clear hidden files and folders from the PR checkout. This improves security by avoiding unintentional remaining files. - Run upload-test-result directly after test-pr and don't wait for comment-pr. There is no dependency on the comment job.
Contributor
Author
|
Successfully tested after merge on a force-push (rebase) on #4790. |
Contributor
|
Looks good, but there is an small edge case where to (before the change, this |
Mynacol
added a commit
to Mynacol/rss-bridge
that referenced
this pull request
Nov 16, 2025
As worked out by @User123698745 in RSS-Bridge#4792 (comment) Introduced in 9e24ad8.
dvikan
pushed a commit
that referenced
this pull request
Nov 16, 2025
* CI: Catch bad whitelist.txt entries As worked out by @User123698745 in #4792 (comment) Introduced in 9e24ad8. * CI: Switch all to ubuntu-24.04-arm runners In my experience, the ARM runners are measurably faster on compute-heavy jobs. PHP should work as before. The container build uses QEMU anyways, so the host CPU architecture only matters in performance. This also upgrades old Ubuntu 22.04 runners to 24.04.
wrobelda
pushed a commit
to wrobelda/rss-bridge
that referenced
this pull request
Nov 18, 2025
* CI: Catch bad whitelist.txt entries As worked out by @User123698745 in RSS-Bridge#4792 (comment) Introduced in 9e24ad8. * CI: Switch all to ubuntu-24.04-arm runners In my experience, the ARM runners are measurably faster on compute-heavy jobs. PHP should work as before. The container build uses QEMU anyways, so the host CPU architecture only matters in performance. This also upgrades old Ubuntu 22.04 runners to 24.04.
wrobelda
pushed a commit
to wrobelda/rss-bridge
that referenced
this pull request
Nov 18, 2025
* CI: Catch bad whitelist.txt entries As worked out by @User123698745 in RSS-Bridge#4792 (comment) Introduced in 9e24ad8. * CI: Switch all to ubuntu-24.04-arm runners In my experience, the ARM runners are measurably faster on compute-heavy jobs. PHP should work as before. The container build uses QEMU anyways, so the host CPU architecture only matters in performance. This also upgrades old Ubuntu 22.04 runners to 24.04.
wrobelda
pushed a commit
to wrobelda/rss-bridge
that referenced
this pull request
Nov 18, 2025
* CI: Catch bad whitelist.txt entries As worked out by @User123698745 in RSS-Bridge#4792 (comment) Introduced in 9e24ad8. * CI: Switch all to ubuntu-24.04-arm runners In my experience, the ARM runners are measurably faster on compute-heavy jobs. PHP should work as before. The container build uses QEMU anyways, so the host CPU architecture only matters in performance. This also upgrades old Ubuntu 22.04 runners to 24.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@User123698745 what do you think?