[doxygen][audio] Fix group names by adding group_ prefix #10094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1078249029
changed the title
unicornx
suggested changes
Mar 9, 2025
There was a problem hiding this comment.
enum 的问题我建议另外提一个 pr 解决，因为这个涉及代码本身修改，不仅仅是注释，可能需要实际的 code owner 来评估。
这个 pr 只解决 #10085 就好。同时参考 https://github.com/plctlab/plct-rt-thread/blob/notes/0.notes/20241212-github-tips.md#3-things-to-note-when-submitting-pr-to-rt-thread 将 PR 和解决的 issue 关联起来。
另外，这个 pr 的 ci-check 说有 “This branch has conflicts that must be resolved”，需要检查一下。
10 tasks
1078249029
force-pushed
the
doxygen_audio_group
branch
2 times, most recently
from
a712a40 to
81faa76
Compare
1078249029
changed the title
1078249029
force-pushed
the
doxygen_audio_group
branch
from
81faa76 to
5e2c907
Compare
unicornx
suggested changes
Mar 10, 2025
There was a problem hiding this comment.
除了空格问题外，请 仔细 阅读 https://github.com/plctlab/plct-rt-thread/blob/notes/0.notes/20241212-github-tips.md#3-things-to-note-when-submitting-pr-to-rt-thread 的说明将 PR 和解决的 issue 关联起来。好处是这个 PR merge 时 github 会自动关闭关联的 issue。
| @@ -136,7 +136,7 @@ | |||
| #define AUDIO_MIXER_MIC 0x0100 /**< Set microphone option */ | |||
| #define AUDIO_MIXER_VITURAL 0x0200 /**< Set virtual audio option */ | |||
| #define AUDIO_MIXER_EXTEND 0x8000 /**< Extend mixer command */ | |||
| /** @} */ /* End of audio_mixer */ | |||
| /** @} */ /* End of group_audio_mixer*/ | |||
| @@ -284,7 +284,7 @@ void rt_audio_rx_done(struct rt_audio_device *audio, rt_uint8_t *pbuf, rt | |||
| #define CODEC_CMD_3D 5 /**< Set 3D effect by codec */ | |||
|
|
|||
| #define CODEC_VOLUME_MAX (63) | |||
| /** @} */ /* End of audio_codec_cmd */ | |||
| /** @} */ /* End of group_audio_codec_cmd*/ | |||
Signed-off-by: 1078249029 <[email protected]>
1078249029
force-pushed
the
doxygen_audio_group
branch
from
5e2c907 to
74a6247
Compare
unicornx
approved these changes
Mar 11, 2025
|
@Rbb666 请 review，没问题请 merge，thanks。 |
Rbb666
approved these changes
Mar 11, 2025
kurisaW
pushed a commit
to kurisaW/rt-thread
that referenced
this pull request
Mar 18, 2025
…0094) Signed-off-by: 1078249029 <[email protected]>
kurisaW
pushed a commit
to kurisaW/rt-thread
that referenced
this pull request
Mar 19, 2025
…0094) Signed-off-by: 1078249029 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
Fixed #10085
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up