Skip to content

#2707; add attribute_source for edge attributes from NGD ovelay#2709

Merged
bazarkua merged 1 commit intomasterfrom
issue-2707
Apr 2, 2026
Merged

#2707; add attribute_source for edge attributes from NGD ovelay#2709
bazarkua merged 1 commit intomasterfrom
issue-2707

Conversation

@saramsey
Copy link
Copy Markdown
Member

@saramsey saramsey commented Apr 1, 2026

see #2707; this commit adds attribute_source information for NGD edge attributes from ARAX-ovelay

@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented Apr 1, 2026

Seems to work on my MBP. This posts the Example 1 query graph and selects for edge attributes returned that have a null attribute_source; it finds no JSON edge attribute objects:

sramsey-laptop:Desktop sramsey$ curl -s -X POST \
-d '{"message":{"query_graph":{"edges":{"e00":{"subject":"n00","object":"n01","predicates":["biolink:interacts_with"]}},"nodes":{"n00":{"ids":["CHEBI:46195"]},"n01":{"categories":["biolink:Protein"]}}}}}' \
-H 'Accept: application/json' \
-H 'Content-type: application/json' \
http://localhost:5001/api/arax/v1.4/query | \
jq '.message.knowledge_graph | .edges[] | .attributes[] | select(.attribute_source == null)'

@bazarkua bazarkua requested a review from Copilot April 1, 2026 22:28
@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented Apr 1, 2026

Running locally on my MBP, the three example queries have all passed

@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented Apr 1, 2026

All 154 standard pytests have passed

@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented Apr 1, 2026

Running on my MBP, the example pathfinder query seems to work

@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented Apr 1, 2026

@bazarkua If after reviewing the results of the Copilot review you feel this patch looks good, feel free to merge to master.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds attribute_source provenance to NGD-related edge attributes produced by ARAX overlay logic, aligning emitted TRAPI edge metadata with infores attribution expectations from #2707.

Changes:

  • Introduces a single attribute_source = 'infores:arax' value used throughout NGD edge-attribute creation.
  • Adds attribute_source to NGD score attributes, virtual relation label, defined datetime, publications, and other edge metadata attributes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bazarkua bazarkua merged commit be772f0 into master Apr 2, 2026
4 checks passed
@saramsey saramsey deleted the issue-2707 branch April 2, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants