-
Notifications
You must be signed in to change notification settings - Fork 33
Use UVParameter forms in UVData.__add__ and UVData.fast_concat to prevent missing parameters. #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e0ef552 to
829fab9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
- Coverage 99.93% 99.93% -0.01%
==========================================
Files 67 67
Lines 22688 22670 -18
==========================================
- Hits 22674 22656 -18
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kartographer this is a slightly different approach than you took in the |
f6b1427 to
33b50d9
Compare
89f562f to
c604805
Compare
945b3a6 to
34449d2
Compare
34449d2 to
a1f87dc
Compare
a1f87dc to
26ed06f
Compare
Description
This is following some of the ideas in UVBase._select_along_axis. This could probably be generalized to UVBase, but I wanted to get UVData's version done to work out the ideas before moving it up UVBase. And I wanted to at least get a draft up for @rlbyrne to try out.
Motivation and Context
fixes #1595
Types of changes
Checklist:
Bug fix checklist: