Skip to content

Conversation

@ldress
Copy link
Contributor

@ldress ldress commented Oct 23, 2025

Description

When reading MWA correlator fits files, the parameter remove_coarse_band is now automatically set to False if the DERIPPLE setting is detected to be on in the metafits file.

Motivation and Context

This change prevents users from accidentally removing a PFB shape that was already corrected in the correlator.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • I have updated the CHANGELOG.

@ldress ldress requested a review from bhazelton October 23, 2025 20:16
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (fd11d22) to head (ca99f09).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          67       67           
  Lines       22619    22627    +8     
=======================================
+ Hits        22605    22613    +8     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but there's one line of code that's not being covered. To see which one, follow the details link next to the codecov check that failed.

The other failing tests were fixed in another PR that we merged, so if you rebase this branch on main those tests should pass.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ldress !

@bhazelton bhazelton merged commit 0797b06 into main Oct 30, 2025
46 checks passed
@bhazelton bhazelton deleted the mwa_deripple_on branch October 30, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants