-
Notifications
You must be signed in to change notification settings - Fork 33
Making uvcalibrate work w/ wideband gains solns #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 67 67
Lines 22682 22688 +6
=======================================
+ Hits 22668 22674 +6
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bhazelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me, but I'd prefer to fix the issue where it errors on MIR by not having it error as long as the polarization conventions agree.
52b09bc to
937bf7a
Compare
|
@bhazelton - okay, I've revised the error condition and put back the |
bhazelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks. I just found one tiny typo.
|
@bhazelton - fixed the minor typo, but now it seems as though I'm running into an unrelated issue w/ the mac ci builds using an out-of-date version of MacOS (see actions/runner-images#13046). |
ea54fdf to
2d5b39c
Compare
This should be fixed in main now (I fixed it in a pre-commit ci PR) |
bhazelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @kartographer !
"I'm going, going... back, back... to cali-bration..."
Description
uvcalibratehas been modified to allow for wide-bandUVCalgains to be applied toUVDataobjects. As part of that, some minor clean-up has been completed withinuvcalibraterelated to spectral window handling.Motivation and Context
Aside from being a requested feature, the above is one of two updates required for directly calibrating SMA data within pyuvdata itself (rather than relying on external programs such as CASA).
Closes #1124.
N.b., a minor modification has been made to the
Mirmodule that causes SMA data so no longer be labeled with a polarization convention due to an error thrown inuvcalibrate. It's unclear whether that error is the desired behavior -- this would be good to get clarification on prior to merging this PR.Types of changes
Checklist:
New feature checklist: