Skip to content

Conversation

@kartographer
Copy link
Contributor

"I'm going, going... back, back... to cali-bration..."

Description

uvcalibrate has been modified to allow for wide-band UVCal gains to be applied to UVData objects. As part of that, some minor clean-up has been completed within uvcalibrate related to spectral window handling.

Motivation and Context

Aside from being a requested feature, the above is one of two updates required for directly calibrating SMA data within pyuvdata itself (rather than relying on external programs such as CASA).

Closes #1124.

N.b., a minor modification has been made to the Mir module that causes SMA data so no longer be labeled with a polarization convention due to an error thrown in uvcalibrate. It's unclear whether that error is the desired behavior -- this would be good to get clarification on prior to merging this PR.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added/updated tests to cover my new feature.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (2920ad9) to head (2d5b39c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1643   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          67       67           
  Lines       22682    22688    +6     
=======================================
+ Hits        22668    22674    +6     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good to me, but I'd prefer to fix the issue where it errors on MIR by not having it error as long as the polarization conventions agree.

@kartographer
Copy link
Contributor Author

@bhazelton - okay, I've revised the error condition and put back the pol_convention for MIR datasets on 00e249a

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks. I just found one tiny typo.

@kartographer
Copy link
Contributor Author

@bhazelton - fixed the minor typo, but now it seems as though I'm running into an unrelated issue w/ the mac ci builds using an out-of-date version of MacOS (see actions/runner-images#13046).

@bhazelton
Copy link
Member

@bhazelton - fixed the minor typo, but now it seems as though I'm running into an unrelated issue w/ the mac ci builds using an out-of-date version of MacOS (see actions/runner-images#13046).

This should be fixed in main now (I fixed it in a pre-commit ci PR)

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @kartographer !

@bhazelton bhazelton merged commit 14b7a8b into main Dec 11, 2025
59 of 60 checks passed
@bhazelton bhazelton deleted the wideband_uvcalibrate branch December 11, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make uvcalibrate support wide-band calibrations

3 participants