Skip to content
This repository has been archived by the owner on Oct 10, 2019. It is now read-only.

Clean up constant_medium::hit() #45

Merged
merged 3 commits into from
Aug 26, 2019
Merged

Clean up constant_medium::hit() #45

merged 3 commits into from
Aug 26, 2019

Conversation

hollasch
Copy link
Collaborator

  • Improve naming of debug control variable.
  • Improve debug logic.
  • Fix whack indentation.
  • Slight code refactor.

Changes to both code & book.

Resolves #44

- Improve naming of debug control variable.
- Improve debug logic.
- Fix whack indentation.
- Slight code refactor.

Changes to both code & book.

Resolves #44
@hollasch hollasch added book Book content code Source code labels Aug 23, 2019
@hollasch hollasch requested a review from trevordblack August 23, 2019 02:39
@hollasch
Copy link
Collaborator Author

@trevordblack — are you set up to compile/test this?

trevordblack
trevordblack previously approved these changes Aug 24, 2019
Copy link
Contributor

@trevordblack trevordblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@trevordblack
Copy link
Contributor

I didn't realize you wanted me to compile it.
Don't merge.

@trevordblack
Copy link
Contributor

Whoops. That was embarrassing.

I built it and got the correct output for participating medium.
It's fine to merge now.

Copy link
Collaborator Author

@hollasch hollasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Trevor!

@hollasch hollasch merged commit 22d404a into master Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
book Book content code Source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to understand hit function in Chapter 8 Volumes
2 participants