Fix refs to random_in_hemisphere #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be random_on_hemisphere. Resolves #1198
hollasch
commented
Aug 12, 2023
| @@ -1819,7 +1819,7 @@ | |||
| bool scatter(const ray& r_in, const hit_record& rec, color& attenuation, ray& scattered) | |||
| const override { | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight | |||
| auto scatter_direction = random_in_hemisphere(rec.normal); | |||
| auto scatter_direction = random_on_hemisphere(rec.normal); | |||
There was a problem hiding this comment.
I think that on is really what we want. If we really do want on, then we'll need to implement it. Also note that this code is quickly replaced later in the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be random_on_hemisphere.
Resolves #1198