-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use litedown for rendering vignettes #6583
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
==========================================
- Coverage 98.59% 98.58% -0.02%
==========================================
Files 79 79
Lines 14665 14665
==========================================
- Hits 14459 14457 -2
- Misses 206 208 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR is on hold until current GH version of |
Earmark: after #6589, if {knitr} is not in |
NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67
It's safe to use litedown:::.env$input
with the current CRAN version of litedown. The next CRAN release should take place in a few weeks, and you'll be able to use litedown::get_context('input')
.
Sorry I meant to push a sub-branch to merge but instead forget to switch and pushed the commit directly. |
@@ -26,9 +26,9 @@ h2 { | |||
} | |||
</style> | |||
|
|||
```{r echo=FALSE, file='_translation_links.R'} | |||
```{r, echo=FALSE, file='_translation_links.R'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i imagine this will later trigger a test for un-named chunks, are names supported in this context?
Closes #6394