Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use litedown for rendering vignettes #6583

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

use litedown for rendering vignettes #6583

wants to merge 15 commits into from

Conversation

ben-schwen
Copy link
Member

Closes #6394

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (9fe1b8d) to head (5ed155d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6583      +/-   ##
==========================================
- Coverage   98.59%   98.58%   -0.02%     
==========================================
  Files          79       79              
  Lines       14665    14665              
==========================================
- Hits        14459    14457       -2     
- Misses        206      208       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
Copy link
Member Author

ben-schwen commented Oct 20, 2024

This PR is on hold until current GH version of xfun makes its way to CRAN.

@MichaelChirico
Copy link
Member

Earmark: after #6589, if {knitr} is not in Suggests it should be in Enhances.

@MichaelChirico
Copy link
Member

NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67

Copy link

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67

It's safe to use litedown:::.env$input with the current CRAN version of litedown. The next CRAN release should take place in a few weeks, and you'll be able to use litedown::get_context('input').

@rikivillalba
Copy link
Contributor

Sorry I meant to push a sub-branch to merge but instead forget to switch and pushed the commit directly.
The commit updates the translation script with litedown and changes instances of `r ...` to `{r} ...` as is recognized by litedown

@@ -26,9 +26,9 @@ h2 {
}
</style>

```{r echo=FALSE, file='_translation_links.R'}
```{r, echo=FALSE, file='_translation_links.R'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i imagine this will later trigger a test for un-named chunks, are names supported in this context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore {litedown} for rendering vignettes
4 participants